Wasmtime GitHub notifications bot (Jul 20 2022 at 15:26): Wasmtime GitHub notifications bot (Jul 20 2022 at 15:26):sparker-arm opened PR #4478 from aarch64-isle-narrow to main:
Fvdemote, snarrow, unarrow and uunarrow.
Also refactor the aarch64 instructions descriptions to parameterize
on ScalarSize instead of using different opcodes.The zero_value pure constructor has been introduced and used by the
integer narrow operations and it replaces, and extends, the compare
zero patterns.Copright (c) 2022, Arm Limited.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 22 2022 at 21:45):cfallin created PR review comment:
(if-let _ ...)has a short form(if ...)that you could use here! And likewise in a few spots below.
Wasmtime GitHub notifications bot (Jul 22 2022 at 21:45):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 22 2022 at 21:45):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 25 2022 at 08:16):sparker-arm submitted PR review.
Wasmtime GitHub notifications bot (Jul 25 2022 at 08:16):sparker-arm created PR review comment:
Ah, nice.
Wasmtime GitHub notifications bot (Jul 25 2022 at 08:37):sparker-arm updated PR #4478 from aarch64-isle-narrow to main.
Wasmtime GitHub notifications bot (Jul 25 2022 at 19:40):cfallin merged PR #4478.
Last updated: Dec 23 2024 at 12:05 UTC