Wasmtime GitHub notifications bot (Jul 19 2022 at 18:29): Wasmtime GitHub notifications bot (Jul 19 2022 at 18:29):jeffcharles opened PR #4468 from jeffcharles.add-apple-silicon-support-for-debugging to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR enables generating debug symbols for AArch64 as described in #4393.
This PR does this by using the same implementation as x86_64. This is needed or an error message is output and compilation fails when enabling generating debug symbols. I've tested debugging a few compiled modules on my M1 with LLDB and debugging seems to work reasonably well (or at least as well as on x86).
Wasmtime GitHub notifications bot (Jul 19 2022 at 18:30):jeffcharles edited PR #4468 from jeffcharles.add-apple-silicon-support-for-debugging to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR enables generating debug symbols for AArch64 as described in #4393.
This PR does this by using the same implementation as x86_64. This is needed or an error message is output and compilation fails when enabling generating debug symbols. I've tested debugging a few compiled modules on my M1 with LLDB and debugging seems to work reasonably well (or at least as well as on x86).
I'm not sure whom to add as a reviewer as there are no suggestions on the right.
Wasmtime GitHub notifications bot (Jul 19 2022 at 18:59):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Jul 19 2022 at 19:01):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jul 19 2022 at 19:01):cfallin has enabled auto merge for PR #4468.
Wasmtime GitHub notifications bot (Jul 19 2022 at 19:12):cfallin merged PR #4468.
Last updated: Oct 23 2024 at 20:03 UTC