Stream: git-wasmtime

Topic: wasmtime / PR #4465 s390x: Small refactoring of ABI code

Wasmtime GitHub notifications bot (Jul 19 2022 at 10:34):

uweigand opened PR #4465 from s390x-abi-refactor to main:

Remove a bit of duplicated code and eliminate some
unnecessary allocations.

FYI @cfallin

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 19 2022 at 15:29):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2022 at 16:07):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2022 at 16:07):

cfallin created PR review comment:

Could we add a comment here describing the invariant? I.e. that registers first_clobbered_gpr..16 are clobbered (a contiguous range)?

(I realize the variable and logic are pre-existing but it's good to clarify while we're passing through :-) )

Wasmtime GitHub notifications bot (Jul 19 2022 at 16:07):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2022 at 16:07):

cfallin created PR review comment:

Could we factor out this loop and link-register conditional (from here and gen_clobber_save above) so we have let (clobbered_fpr, first_clobbered_gpr) = Self::get_clobbered_fpr_gpr(&clobbered_callee_saves[..], outgoing_args_size) ?

Wasmtime GitHub notifications bot (Jul 19 2022 at 16:44):

uweigand updated PR #4465 from s390x-abi-refactor to main.

Wasmtime GitHub notifications bot (Jul 19 2022 at 18:59):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 19 2022 at 18:59):

cfallin merged PR #4465.

Last updated: Dec 23 2024 at 12:05 UTC