Stream: git-wasmtime

Topic: wasmtime / PR #4454 Split `global_asm!` helper macros out...

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:32):

fitzgen opened PR #4454 from split-out-asm-helper-macros to main:

This moves them into a new wasmtime-asm-macros crate that can be used not just
from the wasmtime-fibers crate but also from other crates (e.g. we will need
them in https://github.com/bytecodealliance/wasmtime/pull/4431).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:32):

fitzgen requested alexcrichton for a review on PR #4454.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:36):

alexcrichton created PR review comment:

I think this may need to be =0.40.0 perhaps

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:43):

fitzgen updated PR #4454 from split-out-asm-helper-macros to main.

Wasmtime GitHub notifications bot (Jul 15 2022 at 19:30):

fitzgen updated PR #4454 from split-out-asm-helper-macros to main.

Wasmtime GitHub notifications bot (Jul 15 2022 at 21:10):

fitzgen merged PR #4454.

Last updated: Dec 23 2024 at 12:05 UTC