Stream: git-wasmtime

Topic: wasmtime / PR #4449 x64: Port fdemote and fvdemote to ISLE

Wasmtime GitHub notifications bot (Jul 15 2022 at 00:35):

elliottt opened PR #4449 from trevor/x64-fdemote-fvdemote-isle to main:

• Port fdemote to isle
• Port fvdemote to isle

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 15 2022 at 17:13):

elliottt updated PR #4449 from trevor/x64-fdemote-fvdemote-isle to main.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:59):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:59):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2022 at 18:59):

fitzgen created PR review comment:

Ideally we would just move these opcodes up to the top of the match where the rest of the implemented-in-ISLE opcodes are all matched together.

Wasmtime GitHub notifications bot (Jul 15 2022 at 21:16):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 15 2022 at 21:16):

elliottt created PR review comment:

I'll move them up to the top -- I was matching the surrounding style, figuring that we'd do a pass over this later.

Wasmtime GitHub notifications bot (Jul 15 2022 at 22:53):

elliottt updated PR #4449 from trevor/x64-fdemote-fvdemote-isle to main.

Wasmtime GitHub notifications bot (Jul 15 2022 at 23:22):

elliottt updated PR #4449 from trevor/x64-fdemote-fvdemote-isle to main.

Wasmtime GitHub notifications bot (Jul 18 2022 at 18:40):

elliottt updated PR #4449 from trevor/x64-fdemote-fvdemote-isle to main.

Wasmtime GitHub notifications bot (Jul 18 2022 at 19:45):

elliottt has marked PR #4449 as ready for review.

Wasmtime GitHub notifications bot (Jul 18 2022 at 21:25):

elliottt edited PR #4449 from trevor/x64-fdemote-fvdemote-isle to main:

For the x86_64 backend, port the fdemote and fvdemote instructions. Additionally, add tests to exercise those instructions as well as fpromote and fvpromote_low.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 18 2022 at 21:26):

elliottt merged PR #4449.

Last updated: Dec 23 2024 at 12:05 UTC