Stream: git-wasmtime

Topic: wasmtime / PR #4448 Track type information during compone...

Wasmtime GitHub notifications bot (Jul 14 2022 at 15:45):

alexcrichton opened PR #4448 from track-component-type-information to main:

This commit augments the current translation phase of components with
extra machinery to track the type information of component items such as
instances, components, and functions. The end goal of this commit is to
enable the Lower instruction to know the type of the component
function being lowered. Currently during the inlining pass where
component fusion is detected the type of the lifted function is known,
but to implement fusion entirely the type of the lowered function must
be known. Note that these two types are expected to be different to
allow for the subtyping rules specified by the component model.

For now nothing is actually done with this information other than noting
its presence in the face of a lifted-then-lowered function. My hope
though was to split this out for a separate review to avoid making a
future component-adapter-compiler-containing-PR too large.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 14 2022 at 15:45):

alexcrichton requested fitzgen for a review on PR #4448.

Wasmtime GitHub notifications bot (Jul 14 2022 at 23:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 14 2022 at 23:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 14 2022 at 23:10):

fitzgen created PR review comment:

Should this not go with all the other entities?

Wasmtime GitHub notifications bot (Jul 18 2022 at 14:21):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 18 2022 at 14:21):

alexcrichton created PR review comment:

This is a private indexing type where I basically just didn't want to use usize and isn't otherwise used outside of this file, so I didn't want to put it in that public location.

Wasmtime GitHub notifications bot (Jul 18 2022 at 14:21):

alexcrichton merged PR #4448.

Last updated: Nov 22 2024 at 16:03 UTC