Stream: git-wasmtime

Topic: wasmtime / PR #4438 fuzzgen: Generate stack load/store in...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 11:11):

afonso360 opened PR #4438 from fuzzgen-stack to main:

:wave: Hey,

This PR adds stack slots and stack loads and stores to the functions generated by fuzzgen. We use only the specialized instructions stack_store/stack_load and not the more general combo of stack_addr + store/load.

This also generates random stack slots, that are zero initialized on the first block of the function to prevent reading uninitialized memory.

This has run overnight on a (not very fast) x86 server, and so far hasn't found any issues.

cc: @cfallin @jameysharp

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 14:56):

jameysharp requested jameysharp for a review on PR #4438.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 17:10):

jameysharp created PR review comment:

This change is unnecessary, right? I'd like to keep the simpler syntax unless there's some reason it needs to change.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 17:10):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 17:10):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:11):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:11):

afonso360 created PR review comment:

My editor was complaining that we were always matching on I8 as a variable name and that the others were unused.

But looking at it again it probably would also generate a compile warning, so i think it might be a bug on CLion.

Ill revert this change.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:13):

afonso360 updated PR #4438 from fuzzgen-stack to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:16):

afonso360 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:22):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:22):

jameysharp has enabled auto merge for PR #4438.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2022 at 18:47):

jameysharp merged PR #4438.

Last updated: Dec 23 2024 at 13:07 UTC