Stream: git-wasmtime

Topic: wasmtime / PR #4430 cranelift: Implement table support fo...

Wasmtime GitHub notifications bot (Jul 11 2022 at 19:31):

afonso360 opened PR #4430 from test-tables to main:

:wave: Hey,

As a precursor to adding table support to the interpreter this PR adds support for tables to the runtest environment.

This allows run tests to request memory for tables and for it to be provided via vmctx.

Wasmtime GitHub notifications bot (Jul 11 2022 at 19:32):

afonso360 created PR review comment:

This is a behaviour change from what we had before.

We used to put the start and end pointers. However it looks like that's not whats expected by the bound mechanism for heaps.

This changes it to pass the size in bytes of the heap.

Wasmtime GitHub notifications bot (Jul 11 2022 at 19:32):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 11 2022 at 19:34):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 11 2022 at 19:34):

afonso360 created PR review comment:

This is wrong according to docs/ir.md.

Table bounds should be the number of elements and not the number of bytes.

However nothing works when I change it to that. Probably something to investigate further.

See:
https://github.com/bytecodealliance/wasmtime/blob/1d319c0ec2bcf5a169062eece08f7f78650ce282/cranelift/docs/ir.md?plain=1#L769-L770

Wasmtime GitHub notifications bot (Jul 12 2022 at 14:13):

afonso360 closed without merge PR #4430.

Last updated: Nov 22 2024 at 16:03 UTC