Stream: git-wasmtime

Topic: wasmtime / PR #4427 s390x: Implement full SIMD support

Wasmtime GitHub notifications bot (Jul 09 2022 at 17:42):

uweigand opened PR #4427 from s390x-simd to main:

This adds full support for all Cranelift SIMD instructions
to the s390x target. Everything is matched fully via ISLE.

In addition to adding support for many new instructions,
and the lower.isle code to match all SIMD IR patterns,
this patch also adds ABI support for vector types.
In particular, we now need to handle the fact that
vector registers 8 .. 15 are partially callee-saved,
i.e. the high parts of those registers (which correspond
to the old floating-poing registers) are callee-saved,
but the low parts are not. This is the exact same situation
that we already have on AArch64, and so this patch uses the
same solution (the is_included_in_clobbers callback).

The bulk of the changes are platform-specific, but there are
a few exceptions:

• Added ISLE extractors for the Immediate and Constant types,
  to enable matching the vconst and swizzle instructions.

• Added a missing accessor for call_conv to ABISig.

• Fixed endian conversion for vector types in data_value.rs
  to enable their use in runtests on the big-endian platforms.

• Enabled (nearly) all SIMD runtests on s390x. [ Two test cases
  remain disabled due to vector shift count semantics, see below. ]

• Enabled all Wasmtime SIMD tests on s390x.

There are three minor issues, called out via FIXMEs below,
which should be addressed in the future, but should not be
blockers to getting this patch merged. I've opened the
following issues to track them:

• Vector shift count semantics
  https://github.com/bytecodealliance/wasmtime/issues/4424

• is_included_in_clobbers vs. link register
  https://github.com/bytecodealliance/wasmtime/issues/4425

• gen_constant callback
  https://github.com/bytecodealliance/wasmtime/issues/4426

All tests, including all newly enabled SIMD tests, pass
on both z14 and z15 architectures.

FYI @cfallin

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 09 2022 at 18:16):

uweigand updated PR #4427 from s390x-simd to main.

Wasmtime GitHub notifications bot (Jul 09 2022 at 18:51):

uweigand updated PR #4427 from s390x-simd to main.

Wasmtime GitHub notifications bot (Jul 12 2022 at 15:22):

uweigand updated PR #4427 from s390x-simd to main.

Wasmtime GitHub notifications bot (Jul 18 2022 at 19:54):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 18 2022 at 21:00):

cfallin merged PR #4427.

Last updated: Dec 23 2024 at 12:05 UTC