Stream: git-wasmtime

Topic: wasmtime / PR #4413 cranelift: Use `round_ties_even` for ...

Wasmtime GitHub notifications bot (Jul 07 2022 at 22:51):

afonso360 opened PR #4413 from interp-fix-nearest to main:

As @MaxGraey pointed out (thanks!) in #4397, round has different behavior from nearest. And it looks like the native rust implementation is still pending stabilization.

Right now we duplicate the wasmtime implementation, merged in #2171 since its quite short.

This also adds the missing tests that would have caught this issue.

Wasmtime GitHub notifications bot (Jul 07 2022 at 22:52):

afonso360 edited PR #4413 from interp-fix-nearest to main:

As @MaxGraey pointed out (thanks!) in #4397, round has different behavior from nearest. And it looks like the native rust implementation is still pending stabilization.

Right now we duplicate the wasmtime implementation, merged in #2171 since its quite short.

This also adds the missing tests that would have caught this issue.

Note: I'm happy to replace this with a version that tries to reuse the wasmtime implementation, but it wasn't immediately obvious to me how to do that in a clean manner.

Wasmtime GitHub notifications bot (Jul 07 2022 at 23:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jul 07 2022 at 23:36):

cfallin merged PR #4413.

Last updated: Dec 23 2024 at 12:05 UTC