Stream: git-wasmtime

Topic: wasmtime / PR #4397 cranelift: Implement float rounding o...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 06 2022 at 21:38):

afonso360 opened PR #4397 from interp-rounding to main:

:wave: Hey,

This PR implements the following operations on the interpreter:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 06 2022 at 21:38):

afonso360 edited PR #4397 from interp-rounding to main:

:wave: Hey,

This PR implements the following operations on the interpreter:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 06 2022 at 21:53):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 06 2022 at 22:51):

afonso360 updated PR #4397 from interp-rounding to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 06 2022 at 23:43):

cfallin merged PR #4397.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:26):

MaxGraey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:26):

MaxGraey created PR review comment:

round is not the same as nearest. I think I once implemented the correct nearest in the past: https://github.com/bytecodealliance/wasmtime/pull/2171

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:27):

MaxGraey edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:31):

cfallin created PR review comment:

Ah, sorry I missed this... @afonso360 could you look into this further?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:31):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:48):

MaxGraey created PR review comment:

Rust has not had this operation for very many years. Here it seems someone finally want to add it:
https://github.com/rust-lang/rust/pull/95317

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 20:48):

MaxGraey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 21:26):

afonso360 created PR review comment:

Oh wow! Great catch!

Is there a simple way to organize the code so that we can reuse that implementation?

I'm not sure we can use nightly features in wasmtime/cranelift.

Otherwise we can probably duplicate the function pending stabilization of the rust implementation.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2022 at 21:26):

afonso360 submitted PR review.

Last updated: Nov 22 2024 at 17:03 UTC