Stream: git-wasmtime

Topic: wasmtime / PR #4377 Add rerun-if-changed to fiber/build.rs


view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2022 at 22:16):

iii-i opened PR #4377 from fiber-build-rs to main:

Not having rerun-if-changed leads to including nanosecond-precision
mtimes in fingerprints and unnecessary rebuilds in docker [1].

[1] https://github.com/rust-lang/cargo/blob/0.63.1/src/cargo/core/compiler/fingerprint.rs#L1491

This is a trivial fix.

This is a build issue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2022 at 22:18):

iii-i edited PR #4377 from fiber-build-rs to main:

Not having rerun-if-changed leads to including nanosecond-precision
mtimes in fingerprints and unnecessary rebuilds in docker [1].

[1] https://github.com/rust-lang/cargo/blob/0.63.1/src/cargo/core/compiler/fingerprint.rs#L1491

This is a trivial fix.

This is a build issue.

The list of suggested reviewers is empty.
git log build.rs points to @alexcrichton.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 15:27):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 15:27):

alexcrichton merged PR #4377.


Last updated: Dec 23 2024 at 12:05 UTC