Stream: git-wasmtime

Topic: wasmtime / PR #4377 Add rerun-if-changed to fiber/build.rs

Wasmtime GitHub notifications bot (Jul 04 2022 at 22:16):

iii-i opened PR #4377 from fiber-build-rs to main:

Not having rerun-if-changed leads to including nanosecond-precision
mtimes in fingerprints and unnecessary rebuilds in docker [1].

[1] https://github.com/rust-lang/cargo/blob/0.63.1/src/cargo/core/compiler/fingerprint.rs#L1491

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

This is a trivial fix.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

This is a build issue.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 04 2022 at 22:18):

iii-i edited PR #4377 from fiber-build-rs to main:

Not having rerun-if-changed leads to including nanosecond-precision
mtimes in fingerprints and unnecessary rebuilds in docker [1].

[1] https://github.com/rust-lang/cargo/blob/0.63.1/src/cargo/core/compiler/fingerprint.rs#L1491

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

This is a trivial fix.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

This is a build issue.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

The list of suggested reviewers is empty.
git log build.rs points to @alexcrichton.

Wasmtime GitHub notifications bot (Jul 05 2022 at 15:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 05 2022 at 15:27):

alexcrichton merged PR #4377.

Last updated: Nov 22 2024 at 16:03 UTC