Stream: git-wasmtime

Topic: wasmtime / PR #4373 cranelift: Fix `fmin`/`fmax` in inter...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2022 at 21:11):

afonso360 opened PR #4373 from interp-fminmax to main:

:wave: Hey,

This PR fixes a bug with the interpreter where it is returning the wrong value when comparing 0.0 and -0.0
in fmin and fmax.

This happens because fmin/fmax are defined as returning -0.0 as smaller than 0.0.

However this is not how these values are specified in IEEE754 and the interpreter was
returning the wrong value in these operations since it was just using the standard IEEE754 comparisons.

This also tries to preserve NaN information by avoiding passing NaN's
through any operation that could canonicalize it.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 03 2022 at 21:27):

afonso360 updated PR #4373 from interp-fminmax to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 16:09):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 18:07):

afonso360 updated PR #4373 from interp-fminmax to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 18:19):

afonso360 updated PR #4373 from interp-fminmax to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 18:54):

afonso360 updated PR #4373 from interp-fminmax to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2022 at 19:59):

cfallin merged PR #4373.

Last updated: Nov 22 2024 at 17:03 UTC