dicej opened PR #4370 from component-type-derive-many-variants
to main
:
This addresses #4361. Technically, we now support up to 2^32 variants, which is
the maximum for the canonical ABI. In practice, though, the derived code for
enums with even just 2^16 variants takes a prohibitively long time to compile.Signed-off-by: Joel Dice <joel.dice@fermyon.com>
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
dicej updated PR #4370 from component-type-derive-many-variants
to main
.
dicej updated PR #4370 from component-type-derive-many-variants
to main
.
dicej updated PR #4370 from component-type-derive-many-variants
to main
.
dicej created PR review comment:
It just occurred to me that this could be an
impl TryFrom<usize> for DiscriminantSize
. Let me know if you want me to change it.
dicej submitted PR review.
alexcrichton submitted PR review.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
This is probably due to
PartialEq
/Eq
/etc or just random slow compiler internals. In any case this is fine and I think, as you mentioned, it's ok to skip a test for now.
alexcrichton merged PR #4370.
Last updated: Dec 23 2024 at 12:05 UTC