Stream: git-wasmtime

Topic: wasmtime / PR #4358 aarch64: Implement `bmask`/`bextend` ...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 18:47):

afonso360 opened PR #4358 from aarch64-bmask-isle to main:

:wave: This PR Moves bmask and bextend to ISLE for aarch64.

Additionally as in #4331 we also remove the vector versions of bextend from the documentation.

It would also be a good idea to consider if we want to do the same to bmask since we did a similar thing to bint in #4299 and it looks like that the only implementation of vector bmask is on the interpreter.

cc: @abrown @cfallin @akirilov-arm

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 23:37):

cfallin created PR review comment:

this could use a little more explanation -- "extend to 64 bits first, then this will be all 0s or all 1s and we can duplicate to both halves of 128 bits" maybe?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 23:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 23:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 23:37):

cfallin created PR review comment:

Could we copy this comment over to lower.isle as well?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 01 2022 at 12:00):

afonso360 updated PR #4358 from aarch64-bmask-isle to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 01 2022 at 16:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 01 2022 at 16:37):

cfallin merged PR #4358.

Last updated: Nov 22 2024 at 17:03 UTC