Stream: git-wasmtime

Topic: wasmtime / PR #4355 s390x: clean up lower.rs

Wasmtime GitHub notifications bot (Jun 30 2022 at 07:24):

uweigand opened PR #4355 from s390x-cleanup-lower to main:

Now that lowering is fully done in ISLE, clean up some code remnants
in lower.rs. In particular, move code to lower/isle.rs where
possible, and inline lower_insn_to_regs into its caller and simplify.

CC @cfallin

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 30 2022 at 18:16):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 30 2022 at 18:17):

cfallin merged PR #4355.

Last updated: Dec 23 2024 at 12:05 UTC