Stream: git-wasmtime

Topic: wasmtime / PR #4354 Update may_enter flag handling in com...

Wasmtime GitHub notifications bot (Jun 29 2022 at 17:06):

alexcrichton opened PR #4354 from component-lock to main:

This commit updates the management of the may_enter flag in line with
WebAssembly/component-model#57. Namely the may_enter flag is now
exclusively managed in the canon lift function (which is
TypedFunc::call) and is only unset after post-return completes
successfully. This implements semantics where if any trap happens for
any reason (lifting, lowering, execution, imports, etc) then the
instance is considered permanently poisoned and can no longer be
entered.

Tests needed many updates to create new instances where previously the
same instance was reused after it had an erroneous state.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 29 2022 at 17:06):

alexcrichton requested fitzgen for a review on PR #4354.

Wasmtime GitHub notifications bot (Jun 29 2022 at 21:29):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 29 2022 at 21:31):

alexcrichton merged PR #4354.

Last updated: Dec 23 2024 at 12:05 UTC