Stream: git-wasmtime

Topic: wasmtime / PR #4351 Wasmtime: disable unwind_info unless ...

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:10):

Stebalien opened PR #4351 from fix/disable-unwind-info to main:

Disable the "unwind_info" cranelift feature unless backtraces (or reference types) are enabled. Maintaining unwind info in deeply recursive modules can get expensive.

fixes #4350

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:13):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:15):

Stebalien updated PR #4351 from fix/disable-unwind-info to main.

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:16):

Stebalien submitted PR review.

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:16):

Stebalien submitted PR review.

Wasmtime GitHub notifications bot (Jun 29 2022 at 03:16):

Stebalien created PR review comment:

Note: this is inconsistent with "enable_safepoints", which checks that we don't ahve the reference_types feature enabled. But so is "enable_simd", so I'm not sure which way to go.

Wasmtime GitHub notifications bot (Jun 29 2022 at 15:55):

Stebalien updated PR #4351 from fix/disable-unwind-info to main.

Wasmtime GitHub notifications bot (Jun 29 2022 at 15:59):

Stebalien closed without merge PR #4351.

Wasmtime GitHub notifications bot (Jun 29 2022 at 15:59):

Stebalien reopened PR #4351 from fix/disable-unwind-info to main.

Wasmtime GitHub notifications bot (Jun 29 2022 at 23:33):

Stebalien updated PR #4351 from fix/disable-unwind-info to main.

Wasmtime GitHub notifications bot (Jun 30 2022 at 15:13):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 30 2022 at 15:13):

alexcrichton merged PR #4351.

Last updated: Oct 23 2024 at 20:03 UTC