Stream: git-wasmtime

Topic: wasmtime / PR #4348 Implement a first-class error for ree...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 20:08):

alexcrichton requested fitzgen for a review on PR #4348.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 20:08):

alexcrichton opened PR #4348 from error-reexport to main:

Currently I don't know how we can reasonably implement this. Given all
the signatures of how we call functions and how functions are called on
the host there's no real feasible way that I know of to hook these two
up "seamlessly". This means that a component which reexports an imported
function can't be run in Wasmtime.

One of the main reasons for this is that when calling a component
function Wasmtime wants to lower arguments first and then have them
lifted when the host is called. With a reexport though there's not
actually anything to lower into so we'd sort of need something similar
to a table on the side or maybe a linear memory and that seems like it'd
get quite complicated quite quickly for not really all that much
benefit. As-such for now this simply returns a first-class error (rather
than the current panic) in situations like this.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 22:16):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2022 at 14:05):

alexcrichton merged PR #4348.


Last updated: Dec 23 2024 at 13:07 UTC