Wasmtime GitHub notifications bot (Jun 28 2022 at 20:08): Wasmtime GitHub notifications bot (Jun 28 2022 at 20:08):alexcrichton requested fitzgen for a review on PR #4348.
Wasmtime GitHub notifications bot (Jun 28 2022 at 20:08):alexcrichton opened PR #4348 from error-reexport to main:
Currently I don't know how we can reasonably implement this. Given all
the signatures of how we call functions and how functions are called on
the host there's no real feasible way that I know of to hook these two
up "seamlessly". This means that a component which reexports an imported
function can't be run in Wasmtime.One of the main reasons for this is that when calling a component
function Wasmtime wants to lower arguments first and then have them
lifted when the host is called. With a reexport though there's not
actually anything to lower into so we'd sort of need something similar
to a table on the side or maybe a linear memory and that seems like it'd
get quite complicated quite quickly for not really all that much
benefit. As-such for now this simply returns a first-class error (rather
than the current panic) in situations like this.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 28 2022 at 22:16):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 29 2022 at 14:05):alexcrichton merged PR #4348.
Last updated: Nov 22 2024 at 16:03 UTC