Stream: git-wasmtime

Topic: wasmtime / PR #4341 Fix compilation of wasmtime-fiber on ...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 01:34):

alexcrichton opened PR #4341 from fix-fiber-compile to main:

Turns out that adr doesn't work in inline assembly within LLVM on
arm macOS, or at least not how we were using it. This switches instead
to an adrp and add pair which seems to convince the linker that the
relocations should all fit. The same pattern is used on Linux as well
only it has different syntax (so much for a portable assembler) for
consistency. Performance isn't really an issue here so there's no need
to go out of our way to get the single-instruction operand working.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 13:35):

bnjbvr submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 14:34):

alexcrichton merged PR #4341.


Last updated: Dec 23 2024 at 12:05 UTC