Stream: git-wasmtime

Topic: wasmtime / PR #4341 Fix compilation of wasmtime-fiber on ...

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:34):

alexcrichton opened PR #4341 from fix-fiber-compile to main:

Turns out that adr doesn't work in inline assembly within LLVM on
arm macOS, or at least not how we were using it. This switches instead
to an adrp and add pair which seems to convince the linker that the
relocations should all fit. The same pattern is used on Linux as well
only it has different syntax (so much for a portable assembler) for
consistency. Performance isn't really an issue here so there's no need
to go out of our way to get the single-instruction operand working.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 28 2022 at 13:35):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 14:34):

alexcrichton merged PR #4341.

Last updated: Nov 22 2024 at 16:03 UTC