Stream: git-wasmtime

Topic: wasmtime / PR #4340 Improve error message for failed func...

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:22):

alexcrichton opened PR #4340 from more-func-context to main:

Add in the wasm function index, the name if specified, and the function
offset in the original file to assist in debugging failed function compiles.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:47):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:47):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:47):

peterhuene created PR review comment:

                            "failed to compile wasm function {index}{name} at offset {offset:#x}"

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:47):

peterhuene created PR review comment:

                            Some(name) => format!(" (`{}`)", name),

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:49):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 01:52):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 03:01):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 14:42):

alexcrichton updated PR #4340 from more-func-context to main.

Wasmtime GitHub notifications bot (Jun 28 2022 at 14:42):

alexcrichton has enabled auto merge for PR #4340.

Wasmtime GitHub notifications bot (Jun 28 2022 at 16:06):

alexcrichton requested peterhuene for a review on PR #4340.

Wasmtime GitHub notifications bot (Jun 28 2022 at 17:20):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 17:20):

alexcrichton merged PR #4340.

Last updated: Dec 23 2024 at 12:05 UTC