Stream: git-wasmtime

Topic: wasmtime / PR #4332 Cranelift/x64: fix register allocator...

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:17):

cfallin opened PR #4332 from idiv-x64-8bit-rdx to main:

idiv on x86-64 only reads rdx/edx/dx/dl for divides with width
greater than 8 bits; for an 8-bit divide, it reads the whole 16-bit
divisor from ax, as our CISC ancestors intended. This PR fixes the
metadata to avoid a regalloc panic (due to undefined rdx) in this
case. Does not affect Wasmtime or other Wasm-frontend embedders.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:17):

cfallin requested fitzgen for a review on PR #4332.

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:17):

cfallin requested abrown for a review on PR #4332.

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:35):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:42):

cfallin updated PR #4332 from idiv-x64-8bit-rdx to main.

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:42):

cfallin updated PR #4332 from idiv-x64-8bit-rdx to main.

Wasmtime GitHub notifications bot (Jun 27 2022 at 19:31):

cfallin merged PR #4332.

Last updated: Jan 09 2026 at 13:15 UTC