Stream: git-wasmtime

Topic: wasmtime / PR #4331 aarch64: Implement `ireduce`/`breduce...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 17:49):

afonso360 opened PR #4331 from aarch64-breduce-ireduce-isle to main:

Hey, This moves ireduce and breduce over to ISLE. Its pretty much a copy of the x64 backend since both implementations are equal.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 21:06):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 21:06):

akirilov-arm created PR review comment:

ty_int_bool_ref_scalar_64 is a more accurate choice than fits_in_64.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 21:06):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 21:06):

akirilov-arm created PR review comment:

Ditto.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 20:18):

afonso360 updated PR #4331 from aarch64-breduce-ireduce-isle to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2022 at 11:15):

afonso360 closed without merge PR #4331.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2022 at 11:15):

afonso360 reopened PR #4331 from aarch64-breduce-ireduce-isle to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 10:54):

akirilov-arm created PR review comment:

Were these changes prompted by CI issues?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 10:54):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 11:05):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 11:05):

afonso360 created PR review comment:

Oops, left those in by accident, sorry.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 11:22):

afonso360 updated PR #4331 from aarch64-breduce-ireduce-isle to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 12:17):

akirilov-arm created PR review comment:

I don't think that in the platform-defined way is a useful specification, but the operation is equivalent to the integer one, so you can just repeat the same statement here, i.e. by discarding the most significant bits.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 12:17):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 12:17):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 13:25):

afonso360 updated PR #4331 from aarch64-breduce-ireduce-isle to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 14:12):

akirilov-arm submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 18:15):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2022 at 18:15):

cfallin merged PR #4331.

Last updated: Oct 23 2024 at 20:03 UTC