Stream: git-wasmtime

Topic: wasmtime / PR #4327 Implement lowered-then-lifted functions


view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 15:39):

alexcrichton opened PR #4327 from component-lower-then-lift to main:

This commit is a few features bundled into one, culminating in the
implementation of lowered-then-lifted functions for the component model.
It's probably not going to be used all that often but this is possible
within a valid component so Wasmtime needs to do something relatively
reasonable. The main things implemented in this commit are:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 15:39):

alexcrichton requested fitzgen for a review on PR #4327.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 18:34):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 18:34):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 18:34):

fitzgen created PR review comment:

//      flags: [VMComponentFlags; component.num_runtime_component_instances],

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2022 at 18:34):

fitzgen created PR review comment:

better not to open code / bake in the assumption that the flags will always be one byte large, especially since we wrap them up in a VMComponentFlags data abstraction elsewhere:

            size(flags) = cmul(size_of_vm_component_flags(), ret.num_runtime_component_instances),

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 14:59):

alexcrichton updated PR #4327 from component-lower-then-lift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 14:59):

alexcrichton has enabled auto merge for PR #4327.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 15:25):

alexcrichton updated PR #4327 from component-lower-then-lift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 17:20):

alexcrichton updated PR #4327 from component-lower-then-lift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 18:14):

alexcrichton updated PR #4327 from component-lower-then-lift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 18:16):

alexcrichton updated PR #4327 from component-lower-then-lift to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2022 at 18:50):

alexcrichton merged PR #4327.


Last updated: Dec 23 2024 at 12:05 UTC