alexcrichton opened PR #4326 from refactor-internal-traps
to main
:
This commit is a small refactoring of
wasmtime_runtime::Trap
and
various internals. TheTrap
structure is now a reason plus backtrace,
and the oldTrap
enum is mostly inTrapReason
now. Additionally all
Trap
-returning methods ofwasmtime_runtime
are changed to returning
aTrapCode
to indicate that they never capture a backtrace. Finally
theUnwindReason
internally now no longer duplicates the trap reasons,
instead only having two variants of "panic" and "trap".The motivation for this commit is mostly just cleaning up trap internals
and removing the need for methods like
wasmtime_runtime::Trap::insert_backtrace
to leave it only happening at
thewasmtime
layer.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey submitted PR review.
alexcrichton merged PR #4326.
Last updated: Dec 23 2024 at 12:05 UTC