Stream: git-wasmtime

Topic: wasmtime / PR #4324 Cranelift: update to latest regalloc2...

Wasmtime GitHub notifications bot (Jun 26 2022 at 18:08):

cfallin opened PR #4324 from ra2-better-clobbers-and-less-splitting to main:

• Handle call instructions' clobbers with the clobbers API, using RA2's
  clobbers bitmask (bytecodealliance/regalloc2#58) rather than clobbers
  list;

• Pull in changes from bytecodealliance/regalloc2#59 for much more sane
  edge-case behavior w.r.t. liverange splitting.

Currently refers to local path for RA2 so will fail CI; I will update
this once RA2 PRs 58 and 59 are merged, version-bumped and released.

Fixes #4291.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 26 2022 at 18:08):

cfallin requested alexcrichton for a review on PR #4324.

Wasmtime GitHub notifications bot (Jun 26 2022 at 18:08):

cfallin requested fitzgen for a review on PR #4324.

Wasmtime GitHub notifications bot (Jun 27 2022 at 14:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 14:23):

alexcrichton created PR review comment:

If you've got a git branch/rev to point this to that might be good to use here to turn the crank on Wasmtime's CI to ensure it's green ahead of time.

Wasmtime GitHub notifications bot (Jun 27 2022 at 14:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:12):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:12):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:12):

akirilov-arm created PR review comment:

This is potentially incorrect - the upper 64 bits of q15 might be clobbered by the call on line 196 (or any other until line 203); similarly for the other values produced in the function.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:12):

akirilov-arm created PR review comment:

Ditto.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:30):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 20:30):

cfallin created PR review comment:

Ah, I must have transcribed the clobber details in the ABI incorrectly -- thanks, will take a look!

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:22):

cfallin updated PR #4324 from ra2-better-clobbers-and-less-splitting to main.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:26):

cfallin updated PR #4324 from ra2-better-clobbers-and-less-splitting to main.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:37):

cfallin updated PR #4324 from ra2-better-clobbers-and-less-splitting to main.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:38):

cfallin created PR review comment:

OK, I simply missed a comment about handling of v8 - v15 and mistakenly omitted them from the new clobber lists. Added back, and now we have zero filetest diffs from main in this PR. Thanks for catching this!

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:38):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:38):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:38):

cfallin created PR review comment:

Also fixed as above.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:40):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:40):

cfallin created PR review comment:

Updated to published crate now (I'll use this trick when I'm less lazy in the future though!).

Wasmtime GitHub notifications bot (Jun 27 2022 at 21:40):

cfallin has marked PR #4324 as ready for review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 23:29):

cfallin updated PR #4324 from ra2-better-clobbers-and-less-splitting to main.

Wasmtime GitHub notifications bot (Jun 28 2022 at 16:00):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 16:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 16:01):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Jun 28 2022 at 16:02):

cfallin merged PR #4324.

Last updated: Dec 23 2024 at 13:07 UTC