Wasmtime GitHub notifications bot (Jun 25 2022 at 05:45): Wasmtime GitHub notifications bot (Jun 25 2022 at 05:45):alexcrichton opened PR #4318 from fix-swizzle to main:
This commit fixes a mistake in the
Swizzleopcode implementation in
the x64 backend of Cranelift. Previously an input register was casted to
a writable register and then modified, which I believe instructions are
not supposed to do. This was discovered as part of my investigation
into #4315.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 27 2022 at 17:57):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 27 2022 at 18:20):alexcrichton merged PR #4318.
Last updated: Dec 23 2024 at 12:05 UTC