alexcrichton opened PR #4317 from fix-v128-select
to main
:
This commit fixes a bug in the previous codegen for the
select
instruction when the operations of theselect
were of thev128
type.
Previously tehXmmCmove
instruction only stored anOperandSize
of 32
or 64 for a 64 or 32-bit move, but this was also used for these 128-bit
types which meant that when used the wrong move instruction was
generated. The fix applied here is to store the wholeType
being moved
so the 128-bit variant can be selected as well.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
abrown submitted PR review.
abrown merged PR #4317.
Last updated: Dec 23 2024 at 12:05 UTC