Stream: git-wasmtime

Topic: wasmtime / PR #4317 x64: Fix codegen for the `select` ins...

Wasmtime GitHub notifications bot (Jun 25 2022 at 05:40):

alexcrichton opened PR #4317 from fix-v128-select to main:

This commit fixes a bug in the previous codegen for the select
instruction when the operations of the select were of the v128 type.
Previously teh XmmCmove instruction only stored an OperandSize of 32
or 64 for a 64 or 32-bit move, but this was also used for these 128-bit
types which meant that when used the wrong move instruction was
generated. The fix applied here is to store the whole Type being moved
so the 128-bit variant can be selected as well.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:02):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2022 at 18:02):

abrown merged PR #4317.

Last updated: Dec 13 2025 at 19:03 UTC