Wasmtime GitHub notifications bot (Jun 23 2022 at 23:45): Wasmtime GitHub notifications bot (Jun 23 2022 at 23:45):pchickey opened PR #4312 from pch/trap_unknown_imports to main:
Sometimes users have a Command module which imports functions unknown to
the wasmtime-cli, but does not call them at runtime. This PR provides a
convenience method on Linker to define all unknown import functions in
a given Module as a trivial implementation which traps, and hooks this
up to a new cli flag --trap-unknown-imports.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 23 2022 at 23:45):pchickey requested alexcrichton for a review on PR #4312.
Wasmtime GitHub notifications bot (Jun 24 2022 at 22:53):pchickey updated PR #4312 from pch/trap_unknown_imports to main.
Wasmtime GitHub notifications bot (Jun 27 2022 at 13:55):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 27 2022 at 13:55):alexcrichton merged PR #4312.
Last updated: Nov 22 2024 at 16:03 UTC