Wasmtime GitHub notifications bot (Jun 22 2022 at 13:16): Wasmtime GitHub notifications bot (Jun 22 2022 at 13:16):pepyakin opened PR #4295 from pep-doc-stk-ovf to main:
I realized this when I was reading code while I was hacking on #4109. I figured that this would better be explicitly stated.
Wasmtime GitHub notifications bot (Jun 22 2022 at 14:26):pepyakin updated PR #4295 from pep-doc-stk-ovf to main.
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:20):alexcrichton created PR review comment:
This actually isn't quite accurate in that the stack limit is only set on the first function call, although that's probably important to call out here. For example if wasm is allowed 2M of stack, then if a first wasm call consumes 1M, a host call then consumes 1M, then wasm is reentered it will immediately trap since the limit from the original 2M has been reached.
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:20):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:20):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:48):pepyakin updated PR #4295 from pep-doc-stk-ovf to main.
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:48):pepyakin created PR review comment:
Oh right, I ignored this part I assumed it is reftypes only. Nice to know! 5904b47 should fix that
Wasmtime GitHub notifications bot (Jun 22 2022 at 16:48):pepyakin submitted PR review.
Wasmtime GitHub notifications bot (Jun 22 2022 at 19:02):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 22 2022 at 19:02):alexcrichton merged PR #4295.
Last updated: Oct 23 2024 at 20:03 UTC