Stream: git-wasmtime

Topic: wasmtime / PR #4293 Use Cargo's "namespace features" feature

Wasmtime GitHub notifications bot (Jun 21 2022 at 19:05):

alexcrichton opened PR #4293 from namespace-features to main:

Cargo recently added the ability to have an optional dependency without
implicitly introducing a new named feature on a crate. This is triggered
with some new directives in the [features] section, specifically:

• The dep:foo syntax means that foo is activated but no implicit
  feature should be added named foo.

• Additionally foo?/bar means that the bar feature of foo is only
  activated if foo is otherwise activated elsewhere, for example a
  conditional activation.

These two features can help avoid extra feature names showing up that we
don't want (e.g. currently the wasmtime crate has a rayon feature)
and additionally can help avoid runtime dependencies in niche cases for
us (e.g. activating all-arch but disabling cranelift would
previously pull-in cranelift but no longer will).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 21 2022 at 19:05):

alexcrichton has marked PR #4293 as ready for review.

Wasmtime GitHub notifications bot (Jun 21 2022 at 20:01):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 21 2022 at 20:05):

alexcrichton merged PR #4293.

Last updated: Dec 23 2024 at 12:05 UTC