Wasmtime GitHub notifications bot (Jun 21 2022 at 18:58): Wasmtime GitHub notifications bot (Jun 21 2022 at 18:58):abrown opened PR #4292 from assert-to-err to main:
Previously, @alexcrichton had mentioned that some of these assertions
should be bubbled up as errors. This change re-factors two such
assertions, leaving others in this file as assertions since they
represent code paths that we should avoid internally (not by external
users).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 21 2022 at 18:58):abrown has marked PR #4292 as ready for review.
Wasmtime GitHub notifications bot (Jun 21 2022 at 18:58):abrown requested alexcrichton for a review on PR #4292.
Wasmtime GitHub notifications bot (Jun 21 2022 at 18:59):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 21 2022 at 19:55):abrown merged PR #4292.
Last updated: Dec 23 2024 at 12:05 UTC