Wasmtime GitHub notifications bot (Jun 21 2022 at 14:43): Wasmtime GitHub notifications bot (Jun 21 2022 at 14:43):alexcrichton opened PR #4290 from update-stack-limit-comment to main:
This commit moves the top-level comment in
crates/cranelift/src/lib.rs
into the location where the global value for the stack limit is
generated. Stack overflow checking is pretty localized nowadays so
there's not much need to have it at the top of the crate and most of the
words there were just adapted to this new location.Closes #4286
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 21 2022 at 14:43):alexcrichton has marked PR #4290 as ready for review.
Wasmtime GitHub notifications bot (Jun 21 2022 at 20:08):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 21 2022 at 20:08):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 21 2022 at 20:08):fitzgen created PR review comment:
"recoverable" isn't really the right word here, since the Wasm can't recover from it, only the embedder.
Perhaps
The Wasm spec defines that stack overflows will raise a trap.
?
Wasmtime GitHub notifications bot (Jun 22 2022 at 20:01):alexcrichton updated PR #4290 from update-stack-limit-comment to main.
Wasmtime GitHub notifications bot (Jun 22 2022 at 20:01):alexcrichton merged PR #4290.
Last updated: Oct 23 2024 at 20:03 UTC