Stream: git-wasmtime

Topic: wasmtime / PR #4282 Use `similar` to diff expected and ac...

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:48):

elliottt opened PR #4282 from trevor/diff-filetest-failures to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:51):

elliottt edited PR #4282 from trevor/diff-filetest-failures to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Improve the readability of filetest errors by diffing the expected and actual output. Whereas before you would have to either reconstruct the diff yourself or use CRANELIFT_TEST_BLESS=1 to see the differences with git, error messages now include a diff of the changes in output for lowering tests.

FAIL filetests/filetests/isa/x64/i128.clif: compile

Caused by:
    compilation of function on line 162 does not match
    the text expectation

    --- expected
    +++ actual
    @@ -16,86 +16,87 @@
       setnz   %al
       cmpq    %rdx, %rdi
       setnz   %r8b

    +  movq    %r8, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
       setnz   %r9b
       orq     %r8, %r9, %r8

    -  testq   $1, %r8
    -  setnz   %r8b
    -  movq    %r8, rsp(0 + virtual offset)
    +  movq    %r8, %r9
    +  andq    %r9, $1, %r9
    +  movq    %r9, rsp(0 + virtual offset)
        cmpq    %rcx, %rsi
    ...

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:53):

elliottt edited PR #4282 from trevor/diff-filetest-failures to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Improve the readability of filetest errors by diffing the expected and actual output. Whereas before you would have to either reconstruct the diff yourself or use CRANELIFT_TEST_BLESS=1 to see the differences with git, error messages now include a diff of the changes in output for lowering tests.

FAIL filetests/filetests/isa/x64/i128.clif: compile

Caused by:
    compilation of function on line 162 does not match
    the text expectation

    --- expected
    +++ actual
    @@ -16,86 +16,87 @@
       setnz   %al
       cmpq    %rdx, %rdi
       setnz   %r8b

    +  movq    %r8, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
       setnz   %r9b
       orq     %r8, %r9, %r8

    -  testq   $1, %r8
    -  setnz   %r8b
    -  movq    %r8, rsp(0 + virtual offset)
    +  movq    %r8, %r9
    +  andq    %r9, $1, %r9
    +  movq    %r9, rsp(0 + virtual offset)
        cmpq    %rcx, %rsi
    ...

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:54):

elliottt edited PR #4282 from trevor/diff-filetest-failures to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Improve the readability of filetest errors by diffing the expected and actual output. Whereas before you would have to either reconstruct the diff yourself or use CRANELIFT_TEST_BLESS=1 to see the differences with git, error messages now include a diff of the changes in output for lowering tests.

FAIL filetests/filetests/isa/x64/i128.clif: compile

Caused by:
    compilation of function on line 162 does not match
    the text expectation

    --- expected
    +++ actual
    @@ -16,86 +16,87 @@
       setnz   %al
       cmpq    %rdx, %rdi
       setnz   %r8b

    +  movq    %r8, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
       setnz   %r9b
       orq     %r8, %r9, %r8

    -  testq   $1, %r8
    -  setnz   %r8b
    -  movq    %r8, rsp(0 + virtual offset)
    +  movq    %r8, %r9
    +  andq    %r9, $1, %r9
    +  movq    %r9, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
    ...

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:56):

elliottt edited PR #4282 from trevor/diff-filetest-failures to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Improve the readability of filetest errors by diffing the expected and actual output. Whereas before you would have to either reconstruct the diff yourself or use CRANELIFT_TEST_BLESS=1 to see the differences with git, error messages now include a diff of the changes in output for codegen tests.

FAIL filetests/filetests/isa/x64/i128.clif: compile

Caused by:
    compilation of function on line 162 does not match
    the text expectation

    --- expected
    +++ actual
    @@ -16,86 +16,87 @@
       setnz   %al
       cmpq    %rdx, %rdi
       setnz   %r8b

    +  movq    %r8, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
       setnz   %r9b
       orq     %r8, %r9, %r8

    -  testq   $1, %r8
    -  setnz   %r8b
    -  movq    %r8, rsp(0 + virtual offset)
    +  movq    %r8, %r9
    +  andq    %r9, $1, %r9
    +  movq    %r9, rsp(0 + virtual offset)
       cmpq    %rcx, %rsi
    ...

Wasmtime GitHub notifications bot (Jun 16 2022 at 18:56):

elliottt has marked PR #4282 as ready for review.

Last updated: Dec 23 2024 at 12:05 UTC