Stream: git-wasmtime

Topic: wasmtime / PR #4266 fuzz: allow generating shared memories

Wasmtime GitHub notifications bot (Jun 13 2022 at 18:41):

abrown opened PR #4266 from fuzz-shared-memory to main:

wasm-smith v0.11 has support for generating shared memories when the
threads_enabled configuration flag is set. This change turns on that
flag occasionally.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 13 2022 at 18:46):

abrown updated PR #4266 from fuzz-shared-memory to main.

Wasmtime GitHub notifications bot (Jun 13 2022 at 18:47):

abrown requested alexcrichton for a review on PR #4266.

Wasmtime GitHub notifications bot (Jun 13 2022 at 18:47):

abrown requested fitzgen for a review on PR #4266.

Wasmtime GitHub notifications bot (Jun 13 2022 at 22:34):

abrown created PR review comment:

FYI: this was removed as a cleanup because line 350 below has config.simd_enabled = true;

Wasmtime GitHub notifications bot (Jun 13 2022 at 22:34):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 13 2022 at 22:35):

abrown updated PR #4266 from fuzz-shared-memory to main.

Wasmtime GitHub notifications bot (Jun 13 2022 at 23:48):

abrown updated PR #4266 from fuzz-shared-memory to main.

Wasmtime GitHub notifications bot (Jun 14 2022 at 14:25):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 14 2022 at 14:25):

alexcrichton created PR review comment:

Could this be expanded to include information such as:

• Shared memories are required to be "static" so fuzzing the various memory configurations will mostly result in uninteresting errors. The interesting part about shared memories is the runtime so we don't fuzz non-default settings.
• Shared memories are required to be aligned which means that the CustomUnaligned variant isn't actually safe to use with a shared memory.

Wasmtime GitHub notifications bot (Jun 14 2022 at 14:25):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 14 2022 at 16:06):

abrown updated PR #4266 from fuzz-shared-memory to main.

Wasmtime GitHub notifications bot (Jun 14 2022 at 16:11):

abrown updated PR #4266 from fuzz-shared-memory to main.

Wasmtime GitHub notifications bot (Jun 14 2022 at 16:12):

abrown has marked PR #4266 as ready for review.

Wasmtime GitHub notifications bot (Jun 14 2022 at 16:50):

abrown merged PR #4266.

Last updated: Oct 23 2024 at 20:03 UTC