Stream: git-wasmtime

Topic: wasmtime / PR #4262 Decouple some more `Config` methods f...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 14:07):

alexcrichton opened PR #4262 from defer-more-validation to main:

This commit decouples validation of stack sizes and guard sizes until
Engine::new to avoid odd interactions between the order of invocation
of Config methods.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 14:08):

alexcrichton has marked PR #4262 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 14:08):

alexcrichton updated PR #4262 from defer-more-validation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 14:29):

alexcrichton updated PR #4262 from defer-more-validation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):

cfallin created PR review comment:

same here: . at end

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):

cfallin created PR review comment:

nit: . at end of sentence

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2022 at 14:26):

alexcrichton updated PR #4262 from defer-more-validation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 14 2022 at 14:26):

alexcrichton merged PR #4262.


Last updated: Dec 23 2024 at 13:07 UTC