Wasmtime GitHub notifications bot (Jun 13 2022 at 14:07): Wasmtime GitHub notifications bot (Jun 13 2022 at 14:07):alexcrichton opened PR #4262 from defer-more-validation to main:
This commit decouples validation of stack sizes and guard sizes until
Engine::newto avoid odd interactions between the order of invocation
ofConfigmethods.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 13 2022 at 14:08):alexcrichton has marked PR #4262 as ready for review.
Wasmtime GitHub notifications bot (Jun 13 2022 at 14:08):alexcrichton updated PR #4262 from defer-more-validation to main.
Wasmtime GitHub notifications bot (Jun 13 2022 at 14:29):alexcrichton updated PR #4262 from defer-more-validation to main.
Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):cfallin created PR review comment:
same here:
.at end
Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 13 2022 at 16:27):cfallin created PR review comment:
nit:
.at end of sentence
Wasmtime GitHub notifications bot (Jun 14 2022 at 14:26):alexcrichton updated PR #4262 from defer-more-validation to main.
Wasmtime GitHub notifications bot (Jun 14 2022 at 14:26):alexcrichton merged PR #4262.
Last updated: Nov 22 2024 at 17:03 UTC