Stream: git-wasmtime

Topic: wasmtime / PR #4253 runtime: vmoffsets must be checked in...

Wasmtime GitHub notifications bot (Jun 09 2022 at 23:20):

abrown opened PR #4253 from fix-region-sizes to main:

When adding shared memory, memories owned by the module were added to a
owned_memories array placed immediately after the defined_memories
array. When checking the size of each array with region_sizes, the
size of defined_memories and owned_memories were checked in this
order. But region_sizes is iterating through the fields in the reverse
order. This change reverses the field order to fix the associated fuzz
bug.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 09 2022 at 23:21):

abrown requested alexcrichton for a review on PR #4253.

Wasmtime GitHub notifications bot (Jun 10 2022 at 00:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 10 2022 at 00:53):

alexcrichton merged PR #4253.

Last updated: Nov 22 2024 at 17:03 UTC