Stream: git-wasmtime

Topic: wasmtime / PR #4246 Update wasm-tools crates

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:25):

alexcrichton opened PR #4246 from update-wasm-tools to main:

This commit updates the wasm-tools family of crates, notably pulling in
the refactorings and updates from bytecodealliance/wasm-tools#621 for
the latest iteration of the component model. This commit additionally
updates all support for the component model for these changes, notably:

• Many bits and pieces of type information was refactored. Many
  FooTypeIndex namings are now TypeFooIndex. Additionally there is
  now TypeIndex as well as ComponentTypeIndex for the two type index
  spaces in a component.

• A number of new sections are now processed to handle the core and
  component variants.

• Internal maps were split such as the funcs map into
  component_funcs and funcs (same for instances).

• Canonical options are now processed individually instead of one bulk
  into definition.

Overall this was not a major update to the internals of handling the
component model in Wasmtime. Instead this was mostly a surface-level
refactoring to make sure that everything lines up with the new binary
format for components.

• All text syntax used in tests was updated to the new syntax.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:25):

alexcrichton requested peterhuene for a review on PR #4246.

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:48):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:48):

peterhuene created PR review comment:

Nit: I think this doc comment is wrong?

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:48):

peterhuene created PR review comment:

Nit: TODO doc comment.

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:48):

peterhuene created PR review comment:

Nit: TODO doc comment.

Wasmtime GitHub notifications bot (Jun 08 2022 at 19:48):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Jun 08 2022 at 20:15):

alexcrichton updated PR #4246 from update-wasm-tools to main.

Wasmtime GitHub notifications bot (Jun 09 2022 at 15:38):

alexcrichton updated PR #4246 from update-wasm-tools to main.

Wasmtime GitHub notifications bot (Jun 09 2022 at 15:38):

alexcrichton has marked PR #4246 as ready for review.

Wasmtime GitHub notifications bot (Jun 09 2022 at 16:16):

alexcrichton merged PR #4246.

Last updated: Nov 22 2024 at 17:03 UTC