alexcrichton opened PR #4241 from unit-and-tuple-same
to main
:
This commit updates the implementation of
ComponentType for ()
to
typecheck both the empty tuple type in addition to theunit
type in
the component model. This allows the usage of()
when either of those
types are used. Currently this can work because we don't need to
currently support the answer of "what is the type of this host
function". Instead the only question that needs to be answered at
runtime is "does this host function match this type".<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
alexcrichton requested fitzgen for a review on PR #4241.
fitzgen submitted PR review.
alexcrichton merged PR #4241.
Last updated: Dec 23 2024 at 12:05 UTC