Stream: git-wasmtime

Topic: wasmtime / PR #4239 x64 backend: fix `to_amode` with cons...

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:47):

cfallin requested abrown for a review on PR #4239.

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:47):

cfallin opened PR #4239 from fix-x64-amode-const-addr to main:

If an address expression is given to to_amode that is completely
constant (no registers at all), then it will produce an Amode that has
the resulting constant as an offset, and (invalid_reg) as the base.
This is a side-effect of the way we build up the amode step-by-step --
we're waiting to see a register and plug it into the base field. If we
never get a reg though, we need to generate a constant zero into a
register and use that as the base. This PR adds a finalize_amode
helper to do just that.

Fixes #4234.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:48):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 07 2022 at 18:40):

cfallin merged PR #4239.

Last updated: Dec 23 2024 at 12:05 UTC