Wasmtime GitHub notifications bot (Jun 07 2022 at 15:59): Wasmtime GitHub notifications bot (Jun 07 2022 at 15:59):alexcrichton opened PR #4238 from validate-align to main:
This commit updates the lifting and lowering done by Wasmtime to
validate that alignment is all correct. Previously alignment was ignored
because I wasn't sure how this would all work out.To be extra safe I haven't actually modified any loads/stores and
they're all still unaligned. If this becomes a performance issue we can
investigate aligned loads and stores but otherwise I believe the
requisite locations have been guarded with traps and I've also added
debug asserts to catch possible future mistakes.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 07 2022 at 17:47):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 07 2022 at 17:50):alexcrichton updated PR #4238 from validate-align to main.
Wasmtime GitHub notifications bot (Jun 07 2022 at 18:34):alexcrichton merged PR #4238.
Last updated: Dec 23 2024 at 13:07 UTC