Stream: git-wasmtime

Topic: wasmtime / PR #4233 Update and clean up AssemblyScript ex...

Wasmtime GitHub notifications bot (Jun 07 2022 at 04:51):

JairusSW opened PR #4233 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ x ] This has been discussed in issue #..., or if not, please tell us why
  here.
  The AssemblyScript WASI example in docs/assemblyscript-hello-world was using AssemblyScript v0.19.10 which is out-of-date.

• [ x ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
  This PR updates the AssemblyScript WASI example to the latest version of AssemblyScript, adds a few comments explaining what the code does, and cleans up unnecessary files such as package-lock.json and separating the build files into their own folder for cleanliness.

• [] This PR contains test cases, if meaningful.
  I did manually test it (run npm run build and then npm run wasmtime) and it worked as intended.

• [] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.
  

Wasmtime GitHub notifications bot (Jun 07 2022 at 04:52):

JairusSW edited PR #4233 from main to main:

This PR updates the AssemblyScript WASI example to the latest version of AssemblyScript, adds a few comments explaining what the code does, and cleans up unnecessary files such as package-lock.json and separating the build files into their own folder for cleanliness. I did manually test it (run npm run build and then npm run wasmtime) and it worked as intended.

Wasmtime GitHub notifications bot (Jun 07 2022 at 15:09):

JairusSW updated PR #4233 from main to main.

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:19):

JairusSW updated PR #4233 from main to main.

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:37):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 07 2022 at 17:51):

alexcrichton merged PR #4233.

Last updated: Nov 22 2024 at 17:03 UTC