Stream: git-wasmtime

Topic: wasmtime / PR #4231 cranelift-native flags detection: fix...

Wasmtime GitHub notifications bot (Jun 06 2022 at 23:11):

cfallin opened PR #4231 from fix-x64-baseline-flags to main:

In #4224 we saw that an SSE2-only x86-64 system somehow was still
detecting SSE3/SSSE3/SSE4.1/SSE4.2. It turns out that we enabled these
in the baseline Flags in #3816, because without that, a ton of other
things break: default flags no longer produce a compiler backend that
works with default Wasmtime settings. However the logic to set them when
detected (via CPUID-using feature-test macros) only does an "if
detected then set bit" step per feature; the bits are never cleared.
This PR fixes that.

This should be relatively temporary: once we fix #3810, then we can
remove this hack by making the default Flags state all-zeroes again,
as a compiler with default flags will again support a default Wasmtime.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 06 2022 at 23:11):

cfallin requested abrown for a review on PR #4231.

Wasmtime GitHub notifications bot (Jun 06 2022 at 23:12):

cfallin updated PR #4231 from fix-x64-baseline-flags to main.

Wasmtime GitHub notifications bot (Jun 08 2022 at 20:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 08 2022 at 20:48):

cfallin merged PR #4231.

Last updated: Oct 23 2024 at 20:03 UTC