jlb6740 opened PR #4230 from isle-fpromote
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jlb6740 requested cfallin for a review on PR #4230.
jlb6740 requested abrown for a review on PR #4230.
jlb6740 updated PR #4230 from isle-fpromote
to main
.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
Could you add a space between the term name and the arg list
(Xmm)
here?
cfallin created PR review comment:
Should this be
fpromote
rather thansqrt
here?
jlb6740 created PR review comment:
Strange .. running the wrong test.
jlb6740 submitted PR review.
jlb6740 updated PR #4230 from isle-fpromote
to main
.
cfallin submitted PR review.
jlb6740 merged PR #4230.
Last updated: Dec 23 2024 at 12:05 UTC