Wasmtime GitHub notifications bot (Jun 06 2022 at 17:57): Wasmtime GitHub notifications bot (Jun 06 2022 at 17:57):cfallin opened PR #4229 from isle-integration-update to main:
In #4143, we removed the checked-in-generated-code aspect of the ISLE
build process, in order to simplify the development cycle and reduce
errors. However, I failed to update the docs at the same time. This PR
fixes that. Supersedes #4228 (thanks @jlb6740 for noticing this issue!).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 06 2022 at 17:57):cfallin requested fitzgen for a review on PR #4229.
Wasmtime GitHub notifications bot (Jun 06 2022 at 18:35):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 06 2022 at 18:35):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 06 2022 at 18:35):alexcrichton created PR review comment:
s/dev-dependency/build-dependency/
Wasmtime GitHub notifications bot (Jun 06 2022 at 18:42):cfallin updated PR #4229 from isle-integration-update to main.
Wasmtime GitHub notifications bot (Jun 06 2022 at 19:54):cfallin merged PR #4229.
Last updated: Dec 23 2024 at 12:05 UTC