abrown opened PR #4223 from more-atomics
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
abrown submitted PR review.
abrown created PR review comment:
It feels like this instruction should be proclaiming the fact that it has a side effect but
SideEffectNoResult
doesn't really fit here.
abrown requested cfallin for a review on PR #4223.
cfallin submitted PR review.
cfallin submitted PR review.
cfallin created PR review comment:
I think it's probably fine -- the main point of
SideEffect
was to provide a return value for a thing that nominally doesn't have one, like a store; but here we have a natural value to return. Perhaps the enum is a little misnamed but I can't think of anything better at the moment...
cfallin merged PR #4223.
Last updated: Dec 23 2024 at 12:05 UTC