Stream: git-wasmtime

Topic: wasmtime / PR #4223 x64: port `atomic_cas` to ISLE

Wasmtime GitHub notifications bot (Jun 03 2022 at 23:56):

abrown opened PR #4223 from more-atomics to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 03 2022 at 23:58):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 23:58):

abrown created PR review comment:

It feels like this instruction should be proclaiming the fact that it has a side effect but SideEffectNoResult doesn't really fit here.

Wasmtime GitHub notifications bot (Jun 04 2022 at 03:30):

abrown requested cfallin for a review on PR #4223.

Wasmtime GitHub notifications bot (Jun 06 2022 at 20:20):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2022 at 20:20):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 06 2022 at 20:20):

cfallin created PR review comment:

I think it's probably fine -- the main point of SideEffect was to provide a return value for a thing that nominally doesn't have one, like a store; but here we have a natural value to return. Perhaps the enum is a little misnamed but I can't think of anything better at the moment...

Wasmtime GitHub notifications bot (Jun 06 2022 at 20:20):

cfallin merged PR #4223.

Last updated: Nov 22 2024 at 17:03 UTC