Wasmtime GitHub notifications bot (Jun 04 2022 at 00:17): Wasmtime GitHub notifications bot (Jun 04 2022 at 00:17):cfallin edited PR #4221 from ci-component-model-qemu to main:
Right now the CI test job runs
cargo test --features component-model
on our emulation-based targets as well as native ones. This is fine but
it seems to have become the critical path, at least in some CI jobs I've
been watching. Given that the component model work is mostly (?)
platform-independent, it seems like we get most of the testing value
with our x86-64 platforms, so this PR restricts these tests to only
those platforms.cc @alexcrichton : I don't actually know if the above is completely
true (re: no platform-dependent bits); if there's any risk at all covered
by the tests on these other platforms then please do feel free to
disregard this PR!<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 04 2022 at 00:17):cfallin edited PR #4221 from ci-component-model-qemu to main:
Right now the CI test job runs
cargo test --features component-model
and runs all tests with this feature enabled, which takes a bit of time,
especially on our emulation-based targets. This seems to have become the
critical path, at least in some CI jobs I've been watching. This PR
restricts these runs to only component-model-specific tests when the
feature is enabled.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 04 2022 at 00:22):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 04 2022 at 01:39):alexcrichton merged PR #4221.
Last updated: Nov 22 2024 at 17:03 UTC