Stream: git-wasmtime

Topic: wasmtime / PR #4216 Refactor lifting/lowering to not requ...

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:22):

alexcrichton requested fitzgen for a review on PR #4216.

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:22):

alexcrichton opened PR #4216 from canonical-options-refactor to main:

When lifting and lowering for component host imports there won't be a
Func available to represent the options and such for the lowering.
That means that the current construction of the ComponentValue trait
won't be sufficient for host imports. This commit instead refactors the
traits to instead work with an Options type where the Options type
can be manufactured from thin air out of the arguments passed to the
component host trampolines.

This new Options type is also suitable for storing in WasmStr and
WasmList to continue to be used to refer back to memory after
these lifted values have been given back to the embedder.

Overall this should largely just be shuffling code around and renaming
func: &Func to options: &Options.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:22):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:38):

alexcrichton merged PR #4216.

Last updated: Dec 23 2024 at 12:05 UTC