Stream: git-wasmtime

Topic: wasmtime / PR #4215 Add a `VMComponentContext` type and c...

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:03):

alexcrichton opened PR #4215 from component-vmcomponent to main:

This commit fills out the wasmtime-runtime crate's support for
VMComponentContext and creates it as part of the instantiation
process. This moves a few maps that were temporarily allocated in an
InstanceData into the VMComponentContext and additionally reads the
canonical options data from there instead.

This type still won't be used in its "full glory" until the lowering of
host functions is completely implemented, however, which will be coming
in a future commit.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 03 2022 at 15:03):

alexcrichton requested fitzgen for a review on PR #4215.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:18):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:18):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:18):

fitzgen created PR review comment:

This isn't technically safe right? Since the ComponentInstance is logically pinned, giving out an &mut would allow moving it out by std::mem::replaceing it.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:36):

alexcrichton updated PR #4215 from component-vmcomponent to main.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:36):

alexcrichton created PR review comment:

That's a great point actually and something I totally missed! I removed this, made it a private internal accessor, and reexported &mut self methods from the un-owned version to the owned version.

Wasmtime GitHub notifications bot (Jun 03 2022 at 17:39):

alexcrichton updated PR #4215 from component-vmcomponent to main.

Wasmtime GitHub notifications bot (Jun 03 2022 at 18:34):

alexcrichton merged PR #4215.

Last updated: Oct 23 2024 at 20:03 UTC