Wasmtime GitHub notifications bot (Jun 02 2022 at 18:10): Wasmtime GitHub notifications bot (Jun 02 2022 at 18:10):cfallin opened PR #4211 from fix-cranelift-object-test to main:
Rust 1.61 changed the way
Debugoutput looks for strings with null
bytes in them, which broke some expected-panic error message matches.
This makes the expectations more generic while still capturing the
important part ("has a null byte").Fixes #4210.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 02 2022 at 18:10):cfallin requested abrown for a review on PR #4211.
Wasmtime GitHub notifications bot (Jun 02 2022 at 18:21):abrown submitted PR review.
Wasmtime GitHub notifications bot (Jun 02 2022 at 18:58):cfallin updated PR #4211 from fix-cranelift-object-test to main.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:06):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:06):bjorn3 created PR review comment:
By default integration tests should run even without this. I believe passing
--testswill even disable some things that are enabled by default. See https://doc.rust-lang.org/cargo/commands/cargo-test.html#target-selection for docs.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:06):bjorn3 edited PR review comment.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:14):cfallin updated PR #4211 from fix-cranelift-object-test to main.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:14):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:14):cfallin created PR review comment:
Hmm, yes, looking at the log above again it seems that the test did run in CI even without this flag... it just passed successfully, on Rust 1.61, while locally with Rust 1.61 it fails.
I'll remove the last commit that adds this flag... but we should figure out why the test didn't fail in CI but fails locally. Features different perhaps?
Wasmtime GitHub notifications bot (Jun 02 2022 at 19:34):cfallin edited PR #4211 from fix-cranelift-object-test to main:
Rust 1.61 changed the way
Debugoutput looks for strings with null
bytes in them. Tests currently pass in Rust 1.61 but not with prior versions.
Generally we only support latest stable Rust but here it seems worthwhile
to fix a brittle specific-error-string match. This makes the expectations more
generic while still capturing the important part ("has a null byte").Fixes #4210.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Last updated: Nov 22 2024 at 16:03 UTC